Skip to content

N28: FishFight #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2021
Merged

N28: FishFight #859

merged 4 commits into from
Dec 4, 2021

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented Dec 2, 2021

Part of #852

@not-fl3 not-fl3 force-pushed the fish branch 2 times, most recently from b9be3f9 to 2b6aeb6 Compare December 2, 2021 18:42
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good (made a couple of tweaks but nothing major), but the GIF is over our 2.5MB limit - could you replace it with a smaller version?

I had a go at optimizing it but I could only get it down to 2.45MB - if you have any bright ideas to shrink it more, then that'd be useful, but if not feel free to use my version:

fishfight(1)

@not-fl3
Copy link
Contributor Author

not-fl3 commented Dec 3, 2021

Your optimized GIF looks perfect, updated the PR!

Thanks a lot!

@AngelOnFira AngelOnFira merged commit 9882a24 into rust-gamedev:source Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants